Skip to content

Allow empty or unset NVM_SOURCE in nvm_source() #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow empty or unset NVM_SOURCE in nvm_source() #2807

wants to merge 1 commit into from

Conversation

imme-emosol
Copy link

No description provided.

@ljharb
Copy link
Member

ljharb commented May 11, 2022

This is fine, but since this script isn’t sourced, no options should be set that require this change. Can you elaborate on why it’s needed?

@ljharb ljharb added the installing nvm Problems installing nvm itself label May 11, 2022
@imme-emosol
Copy link
Author

imme-emosol commented May 11, 2022 •
edited
Loading

I sometimes do set -eu in /etc/profile to debug (or even set -eu -vx :| ).

And I do source the file.. so that might be my main issue :]

@ljharb
Copy link
Member

ljharb commented May 11, 2022

In the future, please file issues before PRs - that way permanent, undeleteable, PR refs won't pollute the repo forever.

@ljharb ljharb mentioned this pull request May 11, 2022
Closed
@Joecliff8 Joecliff8 linked an issue May 15, 2022 that may be closed by this pull request
[spam] #2813
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
installing nvm Problems installing nvm itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spam]
2 participants
@imme-emosol @ljharb