-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[readme] clarify instructions for running Node on M1 Mac #2675
Merged
ljharb
merged 1 commit into
nvm-sh:master
from
lukelafountaine:ldlafountaine/clarify-m1-docs
Dec 23, 2021
Merged
[readme] clarify instructions for running Node on M1 Mac #2675
ljharb
merged 1 commit into
nvm-sh:master
from
lukelafountaine:ldlafountaine/clarify-m1-docs
Dec 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This reads much more clearly.
Most of the suggestions are using soft wraps instead of hard wraps, or properly referring to node/node.js.
Thanks for the quick response. Updated with your requested changes. |
ljharb
reviewed
Dec 3, 2021
Back to you @ljharb |
This comment has been minimized.
This comment has been minimized.
ljharb
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a chance to fix my complaints about the previous M1 docs. There were a lot of unnecessary details included and some misleading comments. I think this simplifies the instructions without removing any important pieces of information.