[Fix] exec: -- should stop argument parsing
#2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vesa Vilhonen <[email protected]> Co-authored-by: Sladyn Nunes <[email protected]>
|
thanks, i actually just ran into this a couple days ago myself. |
ljharb
requested changes
Nov 21, 2020
|
Sorry for the delay! Can I somehow run the tests in a docker container? |
|
@vvilhonen you should be able to, but usually i just push changes and let the CI run it :-) |
|
@ljharb https://github.com/sladyn98/nvm/tree/fix/pass-help-in-exec added a test for this pr. |
ljharb
force-pushed
the
fix/pass-help-in-exec
branch
2 times, most recently
from
b0903f6 to
52f67b3
Compare
ljharb
changed the title
exec: -- should stop argument parsing
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
nvm exec stable -- node --helpshows nvm's help, not node's. This change stops help parsing when encountering a--.