-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
ls-remote accepts versions ending with a dot #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
259679b
to
3f333db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great! Can we add a regression test? :-)
2531c6b
to
bebb770
Compare
I would love to add a regression test, what is that? |
In this case, in the same way that |
To clarify; a "regression test" is a test that would have failed without the PR's fix, but now passes - this prevents a regression, or recurrence, of the bug. |
@gitburd is there anything i can help unblock for you on writing a test for this PR? I'd love to get this fix into the next release. |
bebb770
to
fb89405
Compare
Sorry for the delay @ljharb I was blocked by being very ill but I can finally start working again. I added a test to test/fast/Unit tests/nvm_ls_remote, could this work? |
6ec1c1c
to
44cf2f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad you're recovered! This looks great.
44cf2f5
to
c72f2c6
Compare
Issue:
nvm ls-remote will not filter versions ending with "."
Resolves issue #983.
Example:
After change: