[Fix] ensure --help is intercepted on any command
#2277
Merged
+97
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Naomi Quinones <[email protected]> Co-authored-by: Dena Burd <[email protected]>
ljharb
reviewed
Aug 6, 2020
nvm.sh
Outdated
| for i in ${argsList[@]} | ||
| do | ||
| case $i in | ||
| 'help'|'-help'|'--help') |
There was a problem hiding this comment.
I'm a bit surprised to see nvm -help as an alias for nvm --help (i'd totally forgotten about nvm help). Why the extra alias? (typically, single-dash arguments are always only one letter; only double-dash arguments are longer words)
There was a problem hiding this comment.
In case someone were to type one dash either because they are not too familiar with nvm/shell or because it's a typo, then this would catch this variation.
There was a problem hiding this comment.
@ljharb the extra -help is now -h and the test adjusted for it.
|
a few tests are failing. |
naomiquinones
force-pushed
the
check-for-help
branch
from
4b29a6c to
ec62b29
Compare
gitburd
reviewed
Aug 6, 2020
ljharb
changed the title
--help is intercepted on any command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #911
Issue: Prevent flags from being parsed if the help flag is present in the list of arguments to nvm
What we did: Check arguments list for help flag and display help then exit without parsing other flags
Test added: nvm_check_for_help