Skip to content

Update Dockerfile #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

Update Dockerfile #2187

merged 1 commit into from
Mar 31, 2020
+2 −2

Conversation

PeterDaveHello
Copy link
Collaborator

It's a little bit dated, should be updated.

@ljharb ljharb force-pushed the UpdateDockerfile branch from be343a6 to 73438e3 Compare March 31, 2020 06:49
@ljharb ljharb merged commit 73438e3 into nvm-sh:master Mar 31, 2020
@PeterDaveHello PeterDaveHello deleted the UpdateDockerfile branch March 31, 2020 09:43
@PeterDaveHello
Copy link
Collaborator Author

@ljharb why not keep the commit message about shellcheck update?

@ljharb
Copy link
Member

ljharb commented Mar 31, 2020

I suppose i could have kept it in the message; I’ll do that next time. I didn’t think it needed a separate commit, though.

@PeterDaveHello PeterDaveHello mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterDaveHello @ljharb