Make some updates in Travis config #2104
Conversation
| @@ -12,7 +11,6 @@ addons: | |||
| cache: | |||
| ccache: true | |||
| directories: | |||
| - $HOME/.npm | |||
There was a problem hiding this comment.
This is now cached by default.
Please note that as of July 2019, npm is cached by default on Travis CI
There was a problem hiding this comment.
i still prefer the explicit entry; but can you link to where this is quoted from?
There was a problem hiding this comment.
Sure, here is the source, https://docs.travis-ci.com/user/caching/#npm-cache
There was a problem hiding this comment.
I do see the value of being explicit, but the cache policy change is the new norm though :)
There was a problem hiding this comment.
That says
This caches $HOME/.npm or node_modules, depending on the repository’s structure
which makes me more strongly prefer the explicit form.
.travis.yml
Outdated
| @@ -1,6 +1,5 @@ | |||
| language: generic | |||
| dist: xenial | |||
| sudo: required | |||
There was a problem hiding this comment.
This is not quite needed.
There was a problem hiding this comment.
why not? switching from xenial to bionic may have lots of implications about what can be compiled.
There was a problem hiding this comment.
That might be true, but the sudo: required is not needed though.
There was a problem hiding this comment.
They changed in the last Nov:
https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
There was a problem hiding this comment.
i'm fine removing the sudo key, only.
|
Looks like some build failures, some did not. |
|
I will see how to do the cross-linux dist test tomorrow. |
|
Although we're in the process of migrating off of travis, I'll rebase and land this. |
|
Yeah, I can sense the trend of moving away from travis, thanks for adopting this work. |
No description provided.