update error message #1992
Merged
update error message #1992
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jan 24, 2019
nvm.sh
Outdated
| @@ -2322,7 +2322,7 @@ nvm() { | |||
| nvm_echo | |||
| nvm_echo 'Note: <version> refers to any version-like string nvm understands. This includes:' | |||
| nvm_echo ' - full or partial version numbers, starting with an optional "v" (0.10, v0.1.2, v1)' | |||
| nvm_echo " - default (built-in) aliases: ${NVM_NODE_PREFIX}, stable, unstable, ${NVM_IOJS_PREFIX}, system" | |||
| nvm_echo " - default (built-in) aliases: ${NVM_NODE_PREFIX}, stable, unstable, ${NVM_IOJS_PREFIX}" | |||
There was a problem hiding this comment.
"system" is indeed a built-in alias, that will only appear when you do have a system node installed.
nvm.sh
Outdated
| NVM_NODE_PREFIX="$(nvm_node_prefix)" | ||
| case "$1" in | ||
| "stable" | "unstable" | "${NVM_IOJS_PREFIX}" | "${NVM_NODE_PREFIX}") | ||
| nvm_err "${1-} is a default alias and cannot be deleted" |
There was a problem hiding this comment.
i'm going to eventually change the terminology here from default to built-in, so let's use this wording:
Suggested change
| nvm_err "${1-} is a default alias and cannot be deleted" | |
| nvm_err "${1-} is a default (built-in) alias and cannot be deleted" |
nvm.sh
Outdated
| @@ -3325,6 +3325,7 @@ nvm() { | |||
| ;; | |||
| "unalias") | |||
| local NVM_ALIAS_DIR | |||
|
|
|||
There was a problem hiding this comment.
this line of change is not related
|
Thanks for the feedback! |
ljharb
reviewed
Jan 25, 2019
|
I added a test - I'm not confident in my ability to write tests in Urchin so I peeked at the existing tests and used them as a guide. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also I removed a reference to system as a default alias - since as far as I know it is not a default
I ran into the same issue discussed in this closed issue: #1051
I wish I could contribute something more substantial to nvm. Thanks for maintaining this awesome project :)