-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
add libssl-dev to Docker image #1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why? |
because installation of Node.js v0.6.20 in Docker failed due to missing OpenSSL. Unfortunately, I don't have log now |
Log
|
Dockerfile
Outdated
@@ -56,7 +56,8 @@ RUN apt update && \ | |||
g++-4.8 \ | |||
xz-utils \ | |||
build-essential \ | |||
bash-completion && \ | |||
bash-completion \ | |||
libssl-dev && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to move this package upper so that we can focus and minimize the change/diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming it’s ok with @PeterDaveHello
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👍
The commits should be squashed into a single one. |
abbc8a0
to
29d43e4
Compare
@PeterDaveHello commits are squashed into single one |
20b9645
to
7b0a46e
Compare
No description provided.