Skip to content

Update RazorMenu.cshtml #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

jeremy-farrance
Copy link
Contributor

Same as Pull #244 but for Razor. I was not able to test this so, please setup a test.

Related to Issue

Fixes #243

Description

Eliminates extra empty target attributes in menus outputting tags to local links.

How Has This Been Tested?

I was not able to setup a test for this one.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [?] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Same as [Pull nvisionative#244](/nvisionative/pull/244) but for Razor. I was not able to test this so, please setup a test.
Changed empty strings to match existing style
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@david-poindexter david-poindexter self-requested a review October 23, 2020 03:32
@david-poindexter david-poindexter added the enhancement New feature or request label Oct 23, 2020
@david-poindexter david-poindexter added this to the 2.3.0 milestone Oct 23, 2020
@david-poindexter
Copy link
Member

Thank you @jeremy-farrance - I'll review this when I work on the other items I have queued up for the next release. 🎉

@david-poindexter david-poindexter added the on hold On hold label Oct 23, 2020
@david-poindexter david-poindexter removed the on hold On hold label Jun 28, 2021
@david-poindexter david-poindexter changed the base branch from main to develop June 28, 2021 19:42
Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jeremy-farrance - thanks! 🎉
Sorry it took us so long to get to this. 😉

@david-poindexter david-poindexter merged commit e9945db into nvisionative:develop Jun 28, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDR Menus using Token templates have lots of empty Target attribute tags
2 participants