-
-
Notifications
You must be signed in to change notification settings - Fork 41
Prevent missing font #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe it's something else...I now renamed the project-details.json and the nvquicktheme folder is now renamed as well. But...the fonts are still not being loaded.
|
The folder the manifest tells DNN to unpack to is based on the project name within As for the fonts not being loaded, are the font files making it into the install package? Or is it a disconnect within the CSS somewhere? Upon packaging, any reference to the It sounds overall like the packaging went awry, so I'd double check your |
The fonts are making it into the zip. And within the package in the dist.zip |
It shouldn't be woff2 specific as it is setup to zip all files in the dist folder, not specific file types. And I've never had DNN prevent font files from extracting, so this is very puzzling. Within your <!-- CSS, Fonts, JS, Images Folder -->
<component type="ResourceFile">
<resourceFiles>
<basePath>Portals\_default\Skins\{your project name}\</basePath>
<resourceFile>
<name>dist.zip</name>
</resourceFile>
</resourceFiles>
</component> {your project name} should read whatever you have setup in project-details. Does this have the correct path in your |
When you say that the files aren't in the expected folder, are you verifying that on the file system, or through a browser. You do need to add a MIME type mapping for IIS to serve woff2 files. |
@Tychodewaard - I think @bdukes may have nailed this one - thanks Brian! |
I think you're right @bdukes ...never crossed my mind that woff2 is not available by default... |
We have this section in our themes' manifest files:
|
ok, cool. Is yours better? |
@Tychodewaard I think you missed some formatting, GitHub stripped your example |
Hope this works better :-) |
If yours is already in place in the |
Thanks @bdukes for the assist - we'll go ahead and close this issue. |
Do you think it makes sense to add that section to the |
@bdukes for those that have the MIME type already configured in IIS, will this manifest addition cause any issues? |
If the MIME type is configured at the server level (as it is on newer versions of IIS), this will override that configuration (including the the |
FYI, looks like the defaults in IIS 10 (at least on my machine) are |
@bdukes given that, I do not see any reason why that should not be included. Would you like to submit a PR? |
This ensures that the font files which are not mapped by default on older versions of IIS will be mapped, so that IIS will serve them correctly (otherwise it will return a 404). This list is based on the default mappings in IIS 7 (from https://support.microsoft.com/en-us/help/936496) and the MIME types are the defaults from an IIS 10 installation. These additions will override any system-wide defaults set (though they should match the defaults present in newer servers). These instructions will _not_ overwrite any existing mappings in the `web.config` file for the specific site into which the theme is installed (i.e. if `.woff` has already been mapped in the site, this won't change that mapping, but if `.woff2` has not been mapped, that mapping will be added). Any other customizations to the `staticContent` section of the `web.config` file will also be preserved. Fixes nvisionative#60
Uh oh!
There was an error while loading. Please reload this page.
Please summarize your question in one sentence
The fonts are missing.
Give a more extended description
In order to deliver themes that customers can relate to, I rename the install zip to customerA. Which results in themes like CustomerA-default, CustomerA-leftmenu etc.
Result is that the fonts are missing cause they are looking for an nvquicktheme folder
So, somewhere in the code it seems to insist on mentioning nvquicktheme :-)
Any way around this?
Other comments or remarks
The text was updated successfully, but these errors were encountered: