Skip to content

Menu for Enabled vs Disabled Pages with Submenus #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jncraig opened this issue Mar 29, 2019 · 4 comments
Closed

Menu for Enabled vs Disabled Pages with Submenus #148

jncraig opened this issue Mar 29, 2019 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@jncraig
Copy link

jncraig commented Mar 29, 2019

Describe the bug

If a page is enabled for navigation and has subpages, there is a separation between the page name and the down arrow.

if a page is disabled for navigation and has subpages, there is no separation.

To Reproduce

Go to a page with children, and disable the page for navigation. The separator disappears when the page is reloaded.

Expected behavior

The menu entries should look the same. There should not be a hand pointer for disabled pages.

(Note that when the separator appears, the page name and the down arrow have different mouseover characteristics, too.)

Screenshots

If applicable, add screenshots to help explain your problem.

Errors

Paste the error(s) related to this issue.

Additional context

image

@Tychodewaard
Copy link

This is as intended, AFAIK.
If the top level (or any other) is active, you should be able to get to that page by clicking or tapping. But you should also be able to get to pages on sub level by hovering or tapping. That's why there are 2 parts in the button.

If the toplevel is disabled, this is done because it is just a gateway to sublevel and the toplevel has no actual content. So, the ux does not require 2 functions but just one: show me the sub level.

@jncraig
Copy link
Author

jncraig commented Apr 24, 2019 via email

@david-poindexter david-poindexter self-assigned this Apr 25, 2019
@david-poindexter david-poindexter added the question Further information is requested label Apr 25, 2019
@david-poindexter
Copy link
Member

@jncraig the way it is implemented by default is the intended implementation and is the "standard" (common) UX for this type of split menu. This is mainly for mobile (touch) devices so that there is a clear distinction between actions to "expanding the menu" versus "visiting a page". When a page is disabled and has subs, there is only one action for the disabled page (expand the menu) versus two, so there is no need for a split button.

That said, there is no problem in replacing this with an experience you believe better suits your client's or your needs. We do that all the time for our client sites. 😉

We'll go ahead and close this issue out since there are no specific changes to be made to the base starting point. Thanks for the dialog!

@jncraig
Copy link
Author

jncraig commented Apr 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants