Skip to content

feat: add msbuild configuration icons #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GustavEikaas
Copy link
Contributor

@GustavEikaas GustavEikaas commented Dec 30, 2024

Adds icons for msbuild configuration files

reference: vim/vim#16339

Copy link
Collaborator

@hasecilu hasecilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also run make here.

@GustavEikaas
Copy link
Contributor Author

I tried to run make but im running into this issue. I have vim-colortemplate installed. Any hints?

nvim \
        --clean \
        --headless \
        --cmd "set rtp^=vim-colortemplate" \     
        -c 'source scripts/generate_colors.lua' \
        -c 'qall'
Vim:E117: Unknown function: colortemplate#colorspace#approx
lifepillar/vim-colortemplate not present in &runtimepath 'vim-colortemplate,C:\tools\neovim\nvim-win64\share/nvim/runtime,C:\tools
\neovim\nvim-win64\share\nvim\runtime\pack\dist\opt\matchit,C:\tools\neovim\nvim-win64\lib/nvim'
make: *** [Makefile:6: colors] Error 1

@GustavEikaas
Copy link
Contributor Author

Does it look correct now?

@hasecilu
Copy link
Collaborator

I tried to run make but im running into this issue. I have vim-colortemplate installed. Any hints?

What was the problem? Something of windows?

@hasecilu hasecilu force-pushed the feat/add-icons-for-msbuild-config-files branch from 7c2966f to fc43910 Compare December 30, 2024 14:29
@hasecilu hasecilu merged commit 4adeeaa into nvim-tree:master Dec 30, 2024
4 checks passed
@GustavEikaas
Copy link
Contributor Author

What was the problem? Something of windows?

Im not sure tbh. Ended up running the commands inside of vim. Some issue with the headless part apparantly

@GustavEikaas GustavEikaas deleted the feat/add-icons-for-msbuild-config-files branch January 7, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants