feat: native support for mini.icons #1428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Details `mini.icons` is an alternative to `nvim-web-devicons` that is getting support from quite a few plugins. This change adds native support for the plugin so users do not need to mock it via `mock_nvim_web_devicons`. Currently `nvim-web-devicons` is used in the `buffer` and `filetype` components. Created a separate `icons` module to store the icon related logic which now gets used by both of these components. The logic is to first check if `mini.icons` exists and has been setup, if so for the `buffer` component use `get` with the `file` category, for `filetype` use `get` with the `filetype` category. It may make sense to use the `file` category for both. From there the fallback to use `nvim-web-devicons` or `vim-devicons` is kept identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
mini.iconsis an alternative tonvim-web-deviconsthat is getting support from quite a few plugins. This change adds native support for the plugin so users do not need to mock it viamock_nvim_web_devicons.Currently
nvim-web-deviconsis used in thebufferandfiletypecomponents. Created a separateiconsmodule to store the icon related logic which now gets used by both of these components.The logic is to first check if
mini.iconsexists and has been setup, if so for thebuffercomponent usegetwith thefilecategory, forfiletypeusegetwith thefiletypecategory. It may make sense to use thefilecategory for both.From there the fallback to use
nvim-web-deviconsorvim-deviconsis kept identical.If this is something you'd prefer not to have I can understand, the
mock_nvim_web_deviconsis not a bad alternative. Only downsides are all the additional highlight groups and additional startup time formini.icons, but both are minor.