Skip to content

refactor(tpc): move tests to AST instead of code snapshots #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Jun 16, 2024

This PR Refactor TPC tests. Snapshots slows way too much the develomement of TPC. It uses now AST to test the generation of TPC composables

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scripts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 5:51pm
scripts-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 5:51pm

@huang-julien huang-julien changed the title fix(tpc): remove schema in build refactor(tpc): move tests to AST instead of code snapshots Jun 16, 2024
@harlan-zw
Copy link
Collaborator

harlan-zw commented Jun 20, 2024

I admire the code and effort gone into this, but personally, I think a human-readable snapshot is more useful for something that shouldn't be changing that frequently. It also looks like substantially more effort to maintain.

Given you're looking after this though, I am happy to merge, can you just fix the conflict.

@huang-julien
Copy link
Member Author

Thanks ! I'll regen the lockfile then merge it.

The reason behind removing snapshots is that any modification will force to update the snapshot. Moving it to AST allows more flexibility in the code generation without having to update for change.
I admit this is a bit more complex to read but we can remove it later if it is too complex for future contributors.

@huang-julien huang-julien merged commit 8cb62f0 into main Jun 20, 2024
4 checks passed
@huang-julien huang-julien deleted the fix/remove_schema_in_build branch June 20, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants