Skip to content

chore: update nuxt-module-builder to 0.8.0 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024
Merged

chore: update nuxt-module-builder to 0.8.0 #110

merged 2 commits into from
Jun 25, 2024

Conversation

huang-julien
Copy link
Member

πŸ”— Linked issue

#92

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

package update with a build fix

@huang-julien huang-julien requested a review from harlan-zw June 24, 2024 17:14
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
scripts-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 24, 2024 5:25pm
scripts-playground βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 24, 2024 5:25pm

@@ -1,5 +1,5 @@
import { watch } from 'vue'
import type Vimeo from 'vimeo__player'
import type Vimeo from '@vimeo/player'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursed vimeo πŸ˜†

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursed indeed 😩

@harlan-zw
Copy link
Collaborator

This won't fix #92 akaik? The module options will still be broken for the registry key.

@harlan-zw harlan-zw merged commit 4687a75 into main Jun 25, 2024
4 checks passed
@harlan-zw harlan-zw deleted the fix/vimeo branch June 25, 2024 02:09
@huang-julien
Copy link
Member Author

huang-julien commented Jun 25, 2024

Yeah, will look and fix it today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants