Skip to content

fix(tpc): respect script location and action field #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 25, 2024
Merged

fix(tpc): respect script location and action field #105

merged 7 commits into from
Jun 25, 2024

Conversation

huang-julien
Copy link
Member

🔗 Linked issue

❓ Type of change

This PR make the generation of TPC composables respect the location and the position of scripts to add.

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel Vercel
Copy link

vercel bot commented Jun 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scripts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 0:01am
scripts-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 0:01am

@huang-julien huang-julien marked this pull request as ready for review June 24, 2024 11:32
flashdesignory
flashdesignory approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@flashdesignory flashdesignory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at least the script location / action field assignment 😄

@harlan-zw harlan-zw merged commit 6d002c2 into main Jun 25, 2024
4 checks passed
@harlan-zw harlan-zw deleted the fix/respect_tpc_location_and_action branch June 25, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flashdesignory flashdesignory flashdesignory approved these changes

@harlan-zw harlan-zw harlan-zw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huang-julien @flashdesignory @harlan-zw