Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

perf(nitro): respond with early hints in node-based environments #7893

Merged
merged 3 commits into from
Oct 10, 2022
Merged

perf(nitro): respond with early hints in node-based environments #7893

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2ca0a9
perf(nitro): respond with early hints in node-based environments
danielroe Sep 28, 2022
dc2e983
perf: remove extra render cycle on first request
danielroe Sep 28, 2022
55ff9dd
style: remove trailing comma
danielroe Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/nuxt/src/core/runtime/nitro/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createRenderer } from 'vue-bundle-renderer/runtime'
import { createRenderer, renderResourceHeaders } from 'vue-bundle-renderer/runtime'
import type { RenderResponse } from 'nitropack'
import type { Manifest } from 'vite'
import { appendHeader, getQuery } from 'h3'
Expand Down Expand Up @@ -100,7 +100,10 @@ const getSPARenderer = lazyCachedFunction(async () => {
return Promise.resolve(result)
}

return { renderToString }
return {
rendererContext: renderer.rendererContext,
renderToString
}
})

const PAYLOAD_CACHE = (process.env.NUXT_PAYLOAD_EXTRACTION && process.env.prerender) ? new Map() : null // TODO: Use LRU cache
Expand Down Expand Up @@ -150,6 +153,14 @@ export default defineRenderHandler(async (event) => {

// Render app
const renderer = (process.env.NUXT_NO_SSR || ssrContext.noSSR) ? await getSPARenderer() : await getSSRRenderer()

// Render 103 Early Hints
if (!isRenderingPayload && !process.env.prerender && event.res.socket) {
const { link } = renderResourceHeaders({}, renderer.rendererContext)
// TODO: use https://github.com/nodejs/node/pull/44180 when we drop support for node 16
event.res.socket!.write(`HTTP/1.1 103 Early Hints\r\nLink: ${link}\r\n\r\n`, 'utf-8')
}

const _rendered = await renderer.renderToString(ssrContext).catch((err) => {
if (!ssrError) {
// Use explicitly thrown error in preference to subsequent rendering errors
Expand Down