This repository was archived by the owner on Apr 6, 2023. It is now read-only.
refactor(vite): reuse resolved server entry from context #7268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
vite
🍰 p2-nice-to-have
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
approved these changes
Sep 6, 2022
pi0
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
We are already resolving the entrypoint for the app, so I think we can remove this extra code. I see that the
.mjsextension by default in vite node creation was added to fix a bug, so instead I'm moving that logic to the vite server creation so we can share that path (for example) in warming up the app. I'm not sure this makes a difference, but thought it would be better to keep logic central.📝 Checklist