This repository was archived by the owner on Apr 6, 2023. It is now read-only.
feat(nuxt): router with hash mode #6980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#13821
β Type of change
π Description
This PR adds support for hash history mode for router (client only) with a new option. In order to enable:
Remarks:
createWebHashHistory
is super simple. It basically appends#
to the base with location.host and reusecreateWebHistory
. So there is almost no bundle overhead for this optionrouter.options
toapp.router
this way option would be simplerapp.router.hashMode: false
instead ofrouter.options.hashMode: false
.router.mode
from Nuxt 2 is also deprecated. We could portal it but it makes it harder to merge with one options object.TODO:
/#
each timessr: false
withhashMode: true