Skip to content

Rename variable usernameTranlation to usernameTranslation #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

olgahaha
Copy link
Contributor

@olgahaha olgahaha commented Mar 12, 2025

Fixes #3246

Rename the variable 'usernameTranlation' to 'usernameTranslation' in the src/app/features/signup/signup.page.ts file.

  • Rename the variable in the combineLatest observable in the constructor.
  • Rename the variable in the createFormFields method.
  • Update the placeholder property in the form field configuration to use the renamed variable.

For more details, open the Copilot Workspace session.


┆The issue is also created on Asana

Fixes #3246

Rename the variable 'usernameTranlation' to 'usernameTranslation' in the `src/app/features/signup/signup.page.ts` file.

* Rename the variable in the `combineLatest` observable in the constructor.
* Rename the variable in the `createFormFields` method.
* Update the placeholder property in the form field configuration to use the renamed variable.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/numbersprotocol/capture-lite/issues/3246?shareId=XXXX-XXXX-XXXX-XXXX).
@olgahaha olgahaha requested a review from shc261392 March 12, 2025 04:10
@olgahaha olgahaha merged commit 8a42658 into main Mar 12, 2025
9 checks passed
@olgahaha olgahaha deleted the olgahaha/fix-username-translation branch March 12, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not a bug. But I think it might be better to name this variable as "usernameTranslation."
2 participants