escaping new lines and tabs #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lutzifer
reviewed
Apr 7, 2025
Comment on lines
28
to
30
| var finalXmlString = xmlDocument.prettyPrinted | ||
|
|
||
| finalXmlString = finalXmlString.replacingOccurrences(of: "&#", with: "&#") |
There was a problem hiding this comment.
Suggested change
| var finalXmlString = xmlDocument.prettyPrinted | |
| finalXmlString = finalXmlString.replacingOccurrences(of: "&#", with: "&#") | |
| let xmlString = xmlDocument.prettyPrinted | |
| .replacingOccurrences(of: "&#", with: "&#") |
Lutzifer
reviewed
Apr 7, 2025
Comment on lines
18
to
22
| //.replacingOccurrences(of: "%%", with: "%") | ||
| //.replacingOccurrences(of: "«", with: "«") | ||
| //.replacingOccurrences(of: "»", with: "»") | ||
| //.replacingOccurrences(of: "á", with: "á") | ||
| //.replacingOccurrences(of: "é", with: "é") |
There was a problem hiding this comment.
Suggested change
| //.replacingOccurrences(of: "%%", with: "%") | |
| //.replacingOccurrences(of: "«", with: "«") | |
| //.replacingOccurrences(of: "»", with: "»") | |
| //.replacingOccurrences(of: "á", with: "á") | |
| //.replacingOccurrences(of: "é", with: "é") |
Lutzifer
reviewed
Apr 7, 2025
Comment on lines
37
to
41
| let element = XMLElement(name: "string") | ||
| let cleaned = Self.cleanupValueForAndroid(value) | ||
| let textNode = XMLNode(kind: .text) | ||
| textNode.stringValue = cleaned | ||
| element.addChild(textNode) |
There was a problem hiding this comment.
That was my first approach. I had tried to prevent XMLElement from interpreting the string in any way and simply write what is in the source code of the .xcstrings directly (incl. ‘\n’ etc.) into the XML. Later I did the variant with the escaping and apparently forgot to remove the old code. At least I think that's how it was.
Lutzifer
requested changes
Apr 7, 2025
Lutzifer
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.