Skip to content

Add a configuration file to ndpiReader #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

IvanNardi
Copy link
Collaborator

Example:
./example/ndpiReader --conf=./example/calls.conf -i ./tests/pcap/signal_videocall.pcapng -v2

Close #2608

@IvanNardi IvanNardi requested a review from lucaderi November 26, 2024 14:05
@IvanNardi IvanNardi force-pushed the conf-file-ndpireader branch from 7cec07a to d3b9131 Compare November 26, 2024 14:09
Example:
./example/ndpiReader --conf=./example/calls.conf -i ./tests/pcap/signal_videocall.pcapng -v2

Close ntop#2608
@IvanNardi IvanNardi force-pushed the conf-file-ndpireader branch from d3b9131 to bebf7d5 Compare November 26, 2024 14:35
Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary that all config file options need to start with --cfg=? A more intuitive config file would be something like key.subkey = value.

@IvanNardi
Copy link
Collaborator Author

Is it necessary that all config file options need to start with --cfg=? A more intuitive config file would be something like key.subkey = value.

The big advantage of the proposed solution is to keep the same format between ndpiReader command line options and the configuration file: you can simply copy the string between them.

BTW, not ALL config file options start with --cfg= but only the libnDPI ones; ndpiReader options are different (for example -U 0 -p proto.file -P 4:8:10:16:25) but you can copy also the latter as-is into the configuration file.

In other words, for me, the goal of this file is not to be automatically generated, but simply to provide you an easy way to collect all your options together and call them easily via command line

@utoni utoni merged commit 4974f80 into ntop:dev Nov 27, 2024
34 checks passed
@IvanNardi IvanNardi deleted the conf-file-ndpireader branch November 27, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a configuration file to ndpiReader
2 participants