Skip to content

ndpiReader: print how many packets (per flow) were needed to perform full DPI #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

IvanNardi
Copy link
Collaborator

Average values are already printed, but this change should ease to identify regressions/improvements.

Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A feature I've wanted to see.
I would also like to have a counter that prints how many dissector calls per protocol were required to set the detection or exclude a protocol.

@IvanNardi IvanNardi force-pushed the print-dpi-packets-per-flow branch from cab4834 to ce3e492 Compare March 1, 2023 19:38
…full DPI

Average values are already printed, but this change should ease to
identify regressions/improvements.
@IvanNardi IvanNardi force-pushed the print-dpi-packets-per-flow branch from ce3e492 to de0d1c3 Compare March 1, 2023 20:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IvanNardi IvanNardi merged commit 22fb834 into ntop:dev Mar 1, 2023
@IvanNardi IvanNardi deleted the print-dpi-packets-per-flow branch March 1, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants