[#874] WIP: Checkstyle changes for tcg_rim_tool #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chubtub
changed the title
* Updated to upload-artifact@v4 * Updated to download-artifact@v4
…d new events and is located where it should be (var/log/hirs). Ready for PR. (#903)
* v3_issue_905: Finally figured out why we were getting a null pointer exception. Fixed the issue and can now upload plat form certs with unusual components without any hiccups. * v3_issue_905: CI/CD pipeline should be happy now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes bring the tcg_rim_tool into checkstyle conformity according to HIRS/config/checkstyle/checkstyle.xml.
Test instructions: run ./gradlew tools:tcg_rim_tool:checkstyleMain from the HIRS directory and verify that no checkstyle warnings are printed.
Closes #874