[#849] Separate RIM and PCR value validations into distinct methods #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chubtub
changed the title
chubtub
force-pushed
the
v3_issue-849
branch
from
3c2df82 to
ee2e5f7
Compare
|
Pending #899 |
* Updated to upload-artifact@v4 * Updated to download-artifact@v4
…d new events and is located where it should be (var/log/hirs). Ready for PR. (#903)
chubtub
changed the title
* Registry libraries 0.7.5 * Update reference
* Take only first cert in multi part PEM, minimize side effects * Other cases * Github Actions dropping their ubuntu 20 runner
* Updated to upload-artifact@v4 * Updated to download-artifact@v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes separate FirmwareScvValidator.validateFirmware() into two private methods, validateRimSignature() and validatePcrValues().
Closes #849