fix(core): error when restoring http cache with no outputs #30961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 69c5852.
☁️ Nx Cloud last updated this comment at |
AgentEnder
force-pushed
the
fix/no-such-file-or-directory-http-cache
branch
from
0a9de6e to
69c5852
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an error encountered when restoring the HTTP cache when no outputs exist by handling a missing file error gracefully.
- Replaces the forced propagation of copy errors with a match block that handles the NotFound error specifically.
- Introduces a helper method (underlying_io_error_kind) to extract the I/O error kind from the error chain.
Comments suppressed due to low confidence (1)
packages/nx/src/native/cache/cache.rs:304
- [nitpick] The variable name 'sz' is not very descriptive. Consider renaming it to something like 'copied_bytes' to improve code clarity.
let sz = _copy(outputs_path, &self.workspace_root);
FrozenPandaz
approved these changes
Apr 30, 2025
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When restoring remote cache results that did not have any outputs, but the outputs array itself was not empty and using the http remote cache there is an OS Error hit with no such file or directory. This stems from the
_copycall on a non-existant path.Expected Behavior
We don't try to copy a non-existant path
Related Issue(s)
Fixes #30733