feat: suggest lowercase name in capital letter warning #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi maintainers — just a small enhancement PR improving the warning message for mixed-case package names. All tests pass and lint is clean . Would love your feedback or approval when you get a chance. Thank you! |
|
The unrelated changes to new lines is making this harder to review than it needs to be. Please limit changes only to what are needed. |
🤖 I have created a release *beep* *boop* --- [6.0.1](npm/validate-npm-package-name@v6.0.0...v6.0.1) (2025-06-05) * [`68a5c0e`](npm@68a5c0e) [npm#136](npm#136) adding validation for scoped packages that begin with one or more periods (@shmam) * [`99ced75`](npm@99ced75) [npm#136](npm#136) template-oss fixes (@shmam) * [`c45bc37`](npm@c45bc37) [npm#134](npm#134) bump @npmcli/template-oss from 4.23.3 to 4.24.3 (npm#134) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SamiranRai
force-pushed
the
fix-lowercase-warning
branch
from
9abb739 to
bc48a1b
Compare
SamiranRai
force-pushed
the
fix-lowercase-warning
branch
from
bc48a1b to
5a8a0f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Improved the warning message for legacy mixed-case package names in
validate-npm-package-name. Previously, the validator would return a generic warning:"name can no longer contain capital letters".This PR enhances the message to:
"name can no longer contain capital letters. Try: lowercase-version".This small improvement helps developers quickly understand and fix the issue by suggesting a lowercase alternative, improving overall developer experience.