[BUG] Windows Arborist Crash on rollbackMoveBackRetiredUnchanged

[bolshoytoster]

Is there an existing issue for this?

• I have searched the existing issues

This issue exists in the latest npm version

• I am using the latest npm

Current Behavior

npm install can crash when realFolders.get(retireFolder) returns undefined in the following code:

cli/workspaces/arborist/lib/arborist/reify.js

Lines 1065 to 1078 in dd63e21

	[_rollbackMoveBackRetiredUnchanged] (er) {
	const moves = this[_retiredPaths]
	// flip the mapping around to go back
	const realFolders = new Map(Object.entries(moves).map(([k, v]) => [v, k]))
	const promises = Object.entries(this[_retiredUnchanged])
	.map(([retireFolder, nodes]) => promiseAllRejectLate(nodes.map(node => {
	const realFolder = realFolders.get(retireFolder)
	const rel = relative(realFolder, node.path)
	const fromPath = resolve(retireFolder, rel)
	return this[_moveContents]({ ...node, path: fromPath }, node.path)
	})))
	return promiseAllRejectLate(promises)
	.then(() => this[_rollbackCreateSparseTree](er))
	}

Also see log ~line 3459.

Expected Behavior

It shouldn't crash.

Steps To Reproduce

I'm not entirely sure, since I haven't experienced this error. This person has though.

Environment

• npm: v8.4.1
• Node.js: v17.5.0
• OS Name: Windows_NT 10.0.22557
• System Model Name: Don't know
• npm config: Don't know

[fritzy]

I don't have a Windows machine to reproduce this, but it looks like the repo https://github.com/HashLips/hashlips_art_engine might be a good place to try.

[fritzy]

"it sounds like there's a mismatch between this[_retiredPaths] and this[_retiredUnchanged], notably there's this debug block" https://github.com/npm/cli/blob/release-next/workspaces/arborist/lib/arborist/reify.js#L1012-L1024
— @nlf probably