Feature/transaction extensions #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxwoosh
approved these changes
Dec 16, 2024
| @@ -48,88 +81,134 @@ object Extrinsic : Type<Extrinsic.Instance>("ExtrinsicsDecoder") { | |||
| ): Instance { | |||
| val length = compactInt.read(scaleCodecReader) | |||
There was a problem hiding this comment.
It looks like it's not being used anywhere. Is this needed just to be able to read the following values from the reader? What do you think about some kind of cosmetic extension, like skip() to skip unnecessary values?
There was a problem hiding this comment.
Yeah I think we can create something like ScaleCodecReader.skip(dataType) to skip complex things, like compact in this example
|
|
||
| val batchModule = runtime.metadata.module("Utility") | ||
|
|
||
| val batchFunctionName = when (batchMode) { |
There was a problem hiding this comment.
Maybe extract it as enum extension?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements paritytech/polkadot-sdk#3685 in backward compatible manner.
Changes summary of v5 format:
GeneralTransaction. It does not have a hardcoded signature but only has transaction extensions and the call. Signed can be performed using newVerifyMultiSignaturetransaction extensionsign call + extensionstosign current available InheritedImplication, which is a generalized approach introduced in general transactions. You can find more info in the correponding classes' documentation