Update to egui 30 #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using these changes to run egui 0.30.0, so I figured I'd PR them. Sorry if I did things wrong, I am very inexperienced with
crates.io. I presume the changelog section needs to match the date this is merged, so I left the month and date blank in the changelog to be fixed if this is ever ready for merge.Also since this is a new minor release with major 0, the
FnOnce->FnMutchange should be semvar fine. Should that be noted in the change log? I didn't sinceFnMutshould be strictly less restrictive thanFnOnce.I also didn't include it here since I'm not sure if it's desirable, but for me I'd really like if
egui-miniquadre-exportedeguiandminiquadso I don't have to manually make sure the version matches in my project'scargo.toml.