Skip to content

Core Atom: Link #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2018
Merged

Core Atom: Link #107

merged 2 commits into from
Dec 24, 2018

Conversation

arcticicestudio
Copy link
Contributor

Resolves #105

@arcticicestudio
Implement core atom Link component CSS styles
ad114ee 
GH-105
@arcticicestudio
Implement core atom component Link
7cf4e04 
Implemented the core atom `Link` that wraps the base HTML element atom
component the `A` (1) and adds matching brand styles to it.

References:
  (1) #70

Associated epic: GH-63
GH-105
@arcticicestudio arcticicestudio added this to the 0.5.0 milestone Dec 24, 2018
@arcticicestudio arcticicestudio self-assigned this Dec 24, 2018
@codecov
Copy link

codecov bot commented Dec 24, 2018 •
edited
Loading

Codecov Report

Merging #107 into develop will increase coverage by 0.88%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #107      +/-   ##
===========================================
+ Coverage    75.35%   76.24%   +0.88%     
===========================================
  Files           92       94       +2     
  Lines          349      362      +13     
  Branches        37       37              
===========================================
+ Hits           263      276      +13     
  Misses          86       86
Flag Coverage Δ
#unit 76.24% <100%> (+0.88%) ⬆️
Impacted Files Coverage Δ
src/components/atoms/core/Link/Link.jsx 100% <100%> (ø)
src/components/atoms/core/Link/styles.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bee2fb...7cf4e04. Read the comment docs.

@arcticicestudio arcticicestudio merged commit cf1f118 into develop Dec 24, 2018
@arcticicestudio arcticicestudio deleted the feature/gh-105-core-atom-link branch December 24, 2018 09:04
@arcticicestudio arcticicestudio removed their assignment Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-ui scope-ux type-feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb