-
-
Notifications
You must be signed in to change notification settings - Fork 95
descriptionForeground
workbench theme key
#160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
arcticicestudio
added a commit
that referenced
this issue
Oct 3, 2019
Added the `descriptionForeground` workbench theme key that was introduced almost 2 years ago in microsoft/vscode@f450e0b1fe3 (1) for microsoft/vscode#26298 (2), but not mentioned in a changelog so there was no support for it in Nord. It now uses `nord4` with a opacity of 90% as color value (`#d8dee9e6`). References: (1) https://github.com/microsoft/vscode/blame/f450e0b1fe3ac26ce6bf8367ff1bd60fb1387a7d/src/vs/platform/theme/common/colorRegistry.ts#L154 (2) microsoft/vscode#26298 GH-160
arcticicestudio
added a commit
that referenced
this issue
Oct 9, 2019
Added the `descriptionForeground` workbench theme key that was introduced almost 2 years ago in microsoft/vscode@f450e0b1fe3 (1) for microsoft/vscode#26298 (2), but not mentioned in a changelog so there was no support for it in Nord. It now uses `nord4` with a opacity of 90% as color value (`#d8dee9e6`). References: (1) https://github.com/microsoft/vscode/blame/f450e0b1fe3ac26ce6bf8367ff1bd60fb1387a7d/src/vs/platform/theme/common/colorRegistry.ts#L154 (2) microsoft/vscode#26298 Resolves GH-160
sonnyg
pushed a commit
to sonnyg/nord-visual-studio-code
that referenced
this issue
Oct 16, 2019
All documentations and assets have been moved to the official Nord website and documentations (1,2,3). References: (1) https://www.nordtheme.com/ports/visual-studio-code (2) https://www.nordtheme.com/docs/ports/visual-studio-code (3) https://github.com/arcticicestudio/nord-docs nordthemeGH-160
arcticicestudio
added a commit
that referenced
this issue
Dec 23, 2019
Added the `descriptionForeground` workbench theme key that was introduced almost 2 years ago in microsoft/vscode@f450e0b1fe3 (1) for microsoft/vscode#26298 (2), but not mentioned in a changelog so there was no support for it in Nord. It now uses `nord4` with a opacity of 90% as color value (`#d8dee9e6`). References: (1) https://github.com/microsoft/vscode/blame/f450e0b1fe3ac26ce6bf8367ff1bd60fb1387a7d/src/vs/platform/theme/common/colorRegistry.ts#L154 (2) microsoft/vscode#26298 Resolves GH-160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
descriptionForeground
workbench theme key was introduced almost 2 years ago in microsoft/vscode@f450e0b1fe3 for microsoft/vscode#26298, but not mentioned in a changelog so there's currently no support for it in Nord. The key will be added usingnord4
with a opacity of 90% as color value (#d8dee9e6
).The text was updated successfully, but these errors were encountered: