Skip to content

"sunken-button" no longer valid style in emacs master #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cybercode opened this issue Dec 9, 2023 · 1 comment · Fixed by #131
Closed

"sunken-button" no longer valid style in emacs master #130

cybercode opened this issue Dec 9, 2023 · 1 comment · Fixed by #131
Labels
context-ui priority-high scope-compatibility scope-stability
Milestone
0.6.0

Comments

@cybercode
Copy link

cybercode commented Dec 9, 2023 •
edited
Loading

In the latest master branch of emacs (v30), :style sunken-button generates a load error (invalid face). The definition :style pressed-button seems to be the visual equivalent.
cariandrum22 added a commit to cariandrum22/emacs that referenced this issue Feb 18, 2024
@cariandrum22
Fix Invalid face box error (nordtheme#130)
e6977cf 
The `style` attribute `sunken-button` for the `:box` attribute set on a
`button` or `custom-button*` is not a valid value[1].

This was not made manifest by a bug[2] on the emacs side but is expected
to be fixed and become an error in the version 30 release.

In the context of the code, `sunken-button` itself is considered
equivalent to `pressed-button`, so all places where `sunken-button` is
specified have been replaced with `pressed-button`.

[1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html
[2]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67404
masnagam pushed a commit to masnagam/nordtheme-emacs that referenced this issue Feb 25, 2025
@cariandrum22 @masnagam
Fix Invalid face box error (nordtheme#130)
44a426a 
The `style` attribute `sunken-button` for the `:box` attribute set on a
`button` or `custom-button*` is not a valid value[1].

This was not made manifest by a bug[2] on the emacs side but is expected
to be fixed and become an error in the version 30 release.

In the context of the code, `sunken-button` itself is considered
equivalent to `pressed-button`, so all places where `sunken-button` is
specified have been replaced with `pressed-button`.

[1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html
[2]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67404

(cherry picked from commit e6977cf)
@svengreb svengreb self-assigned this Mar 9, 2025
@svengreb svengreb moved this from triage to review in Planning & Roadmaps Mar 9, 2025
@svengreb svengreb added this to the version-next milestone Mar 9, 2025
@svengreb
Copy link
Member

svengreb commented Mar 9, 2025 •
edited
Loading

@cybercode Thank you for your contribution and patience! 🙏🏼
It's been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance. Please keep in mind that maintainers must maintain (pun intended 😁) balance for their open source work and life to avoid burnouts so this gap in time has nothing to do with you or your contribution.

I recently published the first "Northern Post — The state and roadmap of Nord" announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a "clean state". Read the announcement about reaching the "clean" contribution triage state in Nord's discussions for more details about the goal.

Due to the release of Emacs version 30.1 some weeks ago this problem might affect more users that follow the stable release channel so this issue must be resolved as quickly as possible.
With #131 the required changes are already in place so the next release of this theme will include the required change.
This issue has been added to the central and single-source-of-truth project board for the next release.

@svengreb svengreb linked a pull request Mar 9, 2025 that will close this issue
Fix Invalid face box error #131
Merged
svengreb pushed a commit that referenced this issue Mar 9, 2025
@cariandrum22
Fix invalid face for :box error as of Emacs version 30
336a76a 
The style attribute `sunken-button` for the `:box` attribute set on a
`button` or `custom-button*` is not a valid value [1] anymore. It has
always been invalid due to a bug [2] in a previous version as is thrown
as an error as of Emacs version 30.

In the context of the code, `sunken-button` itself is considered
equivalent to `pressed-button`, so all places where `sunken-button` was
specified has been replaced with `pressed-button`.

[1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html
[2]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67404

GH-131
Closes GH-130

Signed-off-by: Sven Greb <[email protected]>
@github-project-automation github-project-automation bot moved this from review to completed in Planning & Roadmaps Mar 9, 2025
@svengreb svengreb removed their assignment Mar 9, 2025
@svengreb svengreb marked this as a duplicate of #133 Mar 9, 2025
@svengreb svengreb mentioned this issue Mar 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui priority-high scope-compatibility scope-stability
Projects
Planning & Roadmaps
Status: completed
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Fix Invalid face box error cariandrum22/emacs
2 participants
@cybercode @svengreb