Add flag to exit process when mocha finishes #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0d3d
force-pushed
the
add-exit-flag
branch
from
0c18867 to
1a14cdb
Compare
|
@mpuittinen do you mind taking a look at this? Thanks! |
mpuittinen
approved these changes
Sep 16, 2018
|
@c0d3d merged and published in [email protected] |
|
Thank you! This helps me out a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Ran into a problem where the plugin didn't kill the process once the tests were complete.
Mocha has a flag to enable this (
--exit), and I would like to use it (and I'm sure others would too).This PR adds a flag to
invokeso that the same behavior can be used. The default behavior is still to "hang".