Skip to content

Add FileType information to the README #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

filipekiss
Copy link
Contributor

Closes #9

@norcalli
Copy link
Owner

Lovely! Thank you. Ha, yeah I didn't publicize the :ReloadBufferColorizer command since it has some edge cases with respecting the options from setup() command because I wanted to avoid global state, but for this purpose, it definitely works well.

@norcalli
Copy link
Owner

Oh, also :ReloadBufferColorizer doesn't attach_to_buffer and continue highlighting, which is another reason why I didn't publicize it. It was for reloading if you changed the settings, but, as I mentioned, that had some edge cases. Maybe I'll add a ColorizerAttachToBuffer command and rename ReloadBufferColorizer to ColorizerReloadBufferOptions.

@filipekiss
Copy link
Contributor Author

I've added the ColorizerAttachToBuffer command as you mentioned on #9. Is the hardcoded 0 ok for this? I'm not sure how the Lua API works regarding buffer numbers :P

@norcalli
Copy link
Owner

Even better! 0 indicates the current buffer in the Lua neovim apis (also for window commands it indicates the current window).

@norcalli
Copy link
Owner

The only thing is that it won't respect the default options if you have used setup() but that's more of a bug and something I'll fix.

@norcalli norcalli merged commit a3dba90 into norcalli:master Oct 18, 2019
@filipekiss
Copy link
Contributor Author

Glad I could help :D Thank you again for the plugin!

@filipekiss filipekiss deleted the add-info-about-filetype branch October 18, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work for *.conf filetypes (and maybe others?)
2 participants