Skip to content

Fix possible dereference of NULL pointer #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix possible dereference of NULL pointer #292

wants to merge 1 commit into from

Conversation

GoldFish2500
Copy link
Contributor

The function uvwasi__malloc may return a null pointer. We must check uv_connect_sock before using it further.

@GoldFish2500 GoldFish2500 reopened this Feb 24, 2025
ospencer
ospencer reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another instance of this for uv_tcp_init.

mhdawson
mhdawson approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@GoldFish2500 I assume this is needed in addition to the 2 other PRs you had submitted? If so could you rebase so we get a test run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer left review comments

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GoldFish2500 @mhdawson @ospencer