Skip to content

fix: cache: treat cache-control request header case-insensitively #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Apr 1, 2025

Closes #3904

This relates to...

Rationale

Changes

Features

N/A

Bug Fixes

Breaking Changes and Deprecations

N/A

Status

@alxndrsn alxndrsn marked this pull request as ready for review April 2, 2025 06:29
@metcoder95 metcoder95 requested a review from mcollina April 23, 2025 10:24
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit fe7aa83 into nodejs:main Apr 23, 2025
27 of 31 checks passed
dhalbrook pushed a commit to dhalbrook/undici that referenced this pull request Apr 24, 2025
…dejs#4131)

* fix: cache: treat cache-control request header case-insensitively

Closes nodejs#3904

* lint; close server after test

* call normaliseHeaders() once

* revert unnecessary change

---------

Co-authored-by: alxndrsn <alxndrsn>
dhalbrook added a commit to dhalbrook/undici that referenced this pull request Apr 24, 2025
@alxndrsn alxndrsn deleted the 3904-cache-control-request-header branch April 25, 2025 06:26
This was referenced May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache interceptor does not process capitalized Cache-Control header in request
4 participants