Skip to content

disable header de-duplication in test servers #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

disable header de-duplication in test servers #4110

merged 1 commit into from
Mar 21, 2025

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Mar 21, 2025 •
edited
Loading

Closes #4109

This relates to...

#4109

Changes

Add joinDuplicateHeaders: true option to every invocation of node:http.createServer() and node:https.createServer().

Features

N/A

Bug Fixes

Breaking Changes and Deprecations

Status

mcollina
mcollina approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95 metcoder95 merged commit 85b8c57 into nodejs:main Mar 21, 2025
28 of 31 checks passed
@github-actions github-actions bot mentioned this pull request May 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test servers may be obscuring bugs
3 participants
@alxndrsn @mcollina @metcoder95