src,lib: obtain sourceURL in magic comments from V8 #58389
+174
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
legendecas
force-pushed
the
source-maps/source-url
branch
from
a0acfc2 to
5c92777
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58389 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.01%
==========================================
Files 633 633
Lines 186902 186922 +20
Branches 36696 36702 +6
==========================================
+ Hits 168672 168673 +1
- Misses 11026 11043 +17
- Partials 7204 7206 +2
🚀 New features to boost your workflow:
|
aduh95
reviewed
May 19, 2025
aduh95
reviewed
May 19, 2025
legendecas
force-pushed
the
source-maps/source-url
branch
from
5c92777 to
0b3cedc
Compare
aduh95
reviewed
May 19, 2025
legendecas
force-pushed
the
source-maps/source-url
branch
2 times, most recently
from
c5c54bc to
d25811d
Compare
|
@aduh95 thanks for suggestions, updated and remove unnecessary replacements. |
aduh95
approved these changes
May 19, 2025
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
May 19, 2025
legendecas
force-pushed
the
source-maps/source-url
branch
from
d25811d to
199a35d
Compare
|
Fixing coverage reports by avoiding normalizing sourceURL. It seems like there are invalid source urls in coverage source maps. |
legendecas
force-pushed
the
source-maps/source-url
branch
from
199a35d to
1f37a43
Compare
Obtain sourceURL magic comments via V8 API to avoid a second round of extraction of magic comments. Updates source map snapshot normalization to allow testing full path names inside the test outputs.
legendecas
force-pushed
the
source-maps/source-url
branch
from
1f37a43 to
c8f2eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obtain sourceURL magic comments via V8 API to avoid a second round of
extraction of magic comments.
Updates source map snapshot normalization to allow testing full path
names inside the test outputs as in test
source-map/output/source_map_eval.snapshot.This is extracted from #52153.