-
-
Notifications
You must be signed in to change notification settings - Fork 32k
lib: avoid event override by assignment #58315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
lib: avoid event override by assignment #58315
Conversation
3c64785
to
7729c3d
Compare
7729c3d
to
a5dce87
Compare
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this last comment, and with some tests (that install an inherited setter and verify it's not called, and then remove the setter, presumably) this PR LGTM
Co-authored-by: Jordan Harband <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58315 +/- ##
==========================================
- Coverage 90.22% 90.12% -0.10%
==========================================
Files 633 639 +6
Lines 186836 188228 +1392
Branches 36678 36911 +233
==========================================
+ Hits 168568 169640 +1072
- Misses 11073 11320 +247
- Partials 7195 7268 +73
🚀 New features to boost your workflow:
|
See #43907