Skip to content

lib: avoid event override by assignment #58315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

erights
Copy link
Contributor

@erights erights commented May 13, 2025

See #43907

@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. labels May 13, 2025
@erights erights force-pushed the markm-avoid-event-override-by-assignment branch from 3c64785 to 7729c3d Compare May 13, 2025 18:11
@erights erights changed the title fix: avoid event override by assignment avoid event override by assignment May 13, 2025
@erights erights force-pushed the markm-avoid-event-override-by-assignment branch from 7729c3d to a5dce87 Compare May 13, 2025 18:14
@erights erights changed the title avoid event override by assignment lib: avoid event override by assignment May 13, 2025
erights and others added 4 commits June 18, 2025 17:32
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this last comment, and with some tests (that install an inherited setter and verify it's not called, and then remove the setter, presumably) this PR LGTM

Co-authored-by: Jordan Harband <[email protected]>
@erights erights marked this pull request as ready for review June 19, 2025 22:31
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (59a763e) to head (fae8feb).
Report is 270 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58315      +/-   ##
==========================================
- Coverage   90.22%   90.12%   -0.10%     
==========================================
  Files         633      639       +6     
  Lines      186836   188228    +1392     
  Branches    36678    36911     +233     
==========================================
+ Hits       168568   169640    +1072     
- Misses      11073    11320     +247     
- Partials     7195     7268      +73     
Files with missing lines Coverage Δ
lib/events.js 99.83% <100.00%> (+0.08%) ⬆️

... and 170 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants