doc: fix CryptoKey.algorithm type and other interfaces in webcrypto.md #58294
+175
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
|
Review requested:
|
flakey5
approved these changes
May 12, 2025
flakey5
added a commit
to nodejs/api-docs-tooling
that referenced
this pull request
May 12, 2025
Mirrors changes in nodejs/node#58294 Signed-off-by: flakey5 <[email protected]> Co-authored-by: Filip Skokan <[email protected]>
panva
added
the
author ready
ovflowd
approved these changes
May 12, 2025
jasnell
approved these changes
May 12, 2025
panva
added
the
commit-queue
panva
commented
May 13, 2025
panva
added
commit-queue-squash
anonrig
approved these changes
May 14, 2025
panva
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1ad8b05 |
flakey5
added a commit
to nodejs/api-docs-tooling
that referenced
this pull request
May 15, 2025
* fix: CryptoKey.algorithm type and other interfaces Mirrors changes in nodejs/node#58294 Signed-off-by: flakey5 <[email protected]> Co-authored-by: Filip Skokan <[email protected]> * Update src/utils/parser/constants.mjs Co-authored-by: Filip Skokan <[email protected]> --------- Co-authored-by: Filip Skokan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #57376
Reminder: the classes referred to in webcrypto.md docs are mere WebIDL interfaces/dictionaries taken from the Web Cryptography API spec, apart from CryptoKey these are not actual classes.