Skip to content

src: remove unused internalVerifyIntegrity internal binding #58285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dario-piotrowicz
Copy link
Member

This PR is removing the internalVerifyIntegrity internal binding, which I believe is no longer used.

I believe that the binding stopped being used in #52583 (see lib/internal/policy/manifest.js line 30).

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 11, 2025
Copy link

codecov bot commented May 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (4a86be2) to head (253bdb8).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58285      +/-   ##
==========================================
+ Coverage   90.18%   90.19%   +0.01%     
==========================================
  Files         631      631              
  Lines      186687   186659      -28     
  Branches    36663    36661       -2     
==========================================
+ Hits       168355   168364       +9     
+ Misses      11124    11100      -24     
+ Partials     7208     7195      -13     
Files with missing lines Coverage Δ
src/crypto/crypto_hash.cc 73.01% <ø> (+5.82%) ⬆️
src/crypto/crypto_hash.h 20.00% <ø> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2025
@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2025
@nodejs-github-bot nodejs-github-bot merged commit fd0d852 into nodejs:main May 13, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fd0d852

@dario-piotrowicz dario-piotrowicz deleted the dario/remove-internalVerifyIntegrity-unused-internal-binding branch May 13, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants