Skip to content

doc: update commit-queue documentation #58275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented May 11, 2025

update the commit-queue contributing documentation by:

  • removing the references of the feature being experimental
  • clarifying that it applies to mergeable pull requests

Note

I'm proposing to remove the references of the feature being experimental since it's been
implemented 5 years ago and I think that it's widely used, so I think that it can be considered
stable at this point

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 11, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/doc/commit-queue-stable branch from de97f6f to 7112fb9 Compare May 11, 2025 12:05
@dario-piotrowicz dario-piotrowicz force-pushed the dario/doc/commit-queue-stable branch 2 times, most recently from dea0b02 to f672e6d Compare May 11, 2025 15:02
update the commit-queue contributing documentation by:
 - removing the references of the feature being experimental
 - clarifying that it applies to mergeable pull requests
@dario-piotrowicz dario-piotrowicz force-pushed the dario/doc/commit-queue-stable branch from f672e6d to 9978e7a Compare May 11, 2025 15:04
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 12, 2025
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2025
@nodejs-github-bot nodejs-github-bot merged commit 656bf7d into nodejs:main May 13, 2025
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 656bf7d

@dario-piotrowicz dario-piotrowicz deleted the dario/doc/commit-queue-stable branch May 13, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants