Skip to content

src: remove unused checkMessagePort internal binding #58267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dario-piotrowicz
Copy link
Member

This PR is removing the checkMessagePort internal binding, which I believe is no longer used.

I believe that the binding stopped being used in #52370.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. typings labels May 10, 2025
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (578a893) to head (912041c).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58267   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         629      629           
  Lines      186639   186623   -16     
  Branches    36654    36663    +9     
=======================================
- Hits       168313   168301   -12     
+ Misses      11134    11115   -19     
- Partials     7192     7207   +15     
Files with missing lines Coverage Δ
src/node_messaging.cc 83.07% <ø> (+0.50%) ⬆️
src/node_messaging.h 63.15% <ø> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@dario-piotrowicz dario-piotrowicz added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 6dcd462 into nodejs:main May 12, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6dcd462

@dario-piotrowicz dario-piotrowicz deleted the dario/remove-checkMessagePort-unused-internal-binding branch May 12, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants