-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
src: remove unused checkMessagePort
internal binding
#58267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
dario-piotrowicz:dario/remove-checkMessagePort-unused-internal-binding
May 12, 2025
Merged
src: remove unused checkMessagePort
internal binding
#58267
nodejs-github-bot
merged 1 commit into
nodejs:main
from
dario-piotrowicz:dario/remove-checkMessagePort-unused-internal-binding
May 12, 2025
+0
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
May 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58267 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 629 629
Lines 186639 186623 -16
Branches 36654 36663 +9
=======================================
- Hits 168313 168301 -12
+ Misses 11134 11115 -19
- Partials 7192 7207 +15
🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 11, 2025
RaisinTen
approved these changes
May 11, 2025
jasnell
approved these changes
May 12, 2025
UlisesGascon
approved these changes
May 12, 2025
legendecas
approved these changes
May 12, 2025
Landed in 6dcd462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
typings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is removing the
checkMessagePort
internal binding, which I believe is no longer used.I believe that the binding stopped being used in #52370.