doc: update stability status for diagnostics_channel to experimental #58261
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
diagnostics_channel
jasnell
approved these changes
May 10, 2025
geeksilva97
approved these changes
May 10, 2025
anonrig
approved these changes
May 10, 2025
idango10
commented
May 10, 2025
Comment on lines
-1106
to
-1111
| > Stability: 1 - Experimental | ||
| While the diagnostics\_channel API is now considered stable, the built-in | ||
| channels currently available are not. Each channel must be declared stable | ||
| independently. | ||
|
|
There was a problem hiding this comment.
I was initially unsure whether this part should be removed, but after seeing the CI fail due to a duplicate stability status inherited from the parent (https://github.com/nodejs/node/actions/runs/14946879215/job/41993454082?pr=58261), it seems that it needs to be taken out.
Closed
RaisinTen
reviewed
May 12, 2025
Added 😃 |
RaisinTen
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58261 ✔ Done loading data for nodejs/node/pull/58261 ----------------------------------- PR info ------------------------------------ Title doc: update stability status for diagnostics_channel to experimental (#58261) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch idango10:idango/fix-58234 -> nodejs:main Labels doc, author ready, diagnostics_channel, commit-queue-squash Commits 4 - doc: update stability status for diagnostics_channel to experimental - fix: remove duplicate stability status from the parent - Merge branch 'main' into idango/fix-58234 - doc: add experimental status to HTTP/2 Committers 2 - idango10 <[email protected]> - idango10 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58261 Fixes: https://github.com/nodejs/node/issues/58234 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58261 Fixes: https://github.com/nodejs/node/issues/58234 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 10 May 2025 15:53:05 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58261#pullrequestreview-2830922678 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/58261#pullrequestreview-2830929787 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58261#pullrequestreview-2831018048 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/58261#pullrequestreview-2833122690 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 58261 From https://github.com/nodejs/node * branch refs/pull/58261/merge -> FETCH_HEAD ✔ Fetched commits as 2281a04e5e38..47a213a8ca55 -------------------------------------------------------------------------------- Auto-merging doc/api/diagnostics_channel.md [main 5647bcd117] doc: update stability status for diagnostics_channel to experimental Author: idango10 <[email protected]> Date: Sat May 10 18:51:38 2025 +0300 1 file changed, 14 insertions(+) Auto-merging doc/api/diagnostics_channel.md error: commit 5d760725011411d86dc48b2b62ecaf8c7b88e65e is a merge but no -m option was given. fatal: cherry-pick failed [main b6be9672b9] fix: remove duplicate stability status from the parent Author: idango10 <[email protected]> Date: Sat May 10 21:11:54 2025 +0300 1 file changed, 6 deletions(-) ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/14976819325 |
@RaisinTen looks like the |
geeksilva97
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58261 ✔ Done loading data for nodejs/node/pull/58261 ----------------------------------- PR info ------------------------------------ Title doc: update stability status for diagnostics_channel to experimental (#58261) Author Idan Goshen <[email protected]> (@idango10, first-time contributor) Branch idango10:idango/fix-58234 -> nodejs:main Labels doc, author ready, diagnostics_channel, commit-queue-squash Commits 4 - doc: update stability status for diagnostics_channel to experimental - fix: remove duplicate stability status from the parent - Merge branch 'main' into idango/fix-58234 - doc: add experimental status to HTTP/2 Committers 2 - idango10 <[email protected]> - idango10 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58261 Fixes: https://github.com/nodejs/node/issues/58234 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58261 Fixes: https://github.com/nodejs/node/issues/58234 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 10 May 2025 15:53:05 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58261#pullrequestreview-2830922678 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/58261#pullrequestreview-2830929787 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58261#pullrequestreview-2831018048 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/58261#pullrequestreview-2833122690 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 58261 From https://github.com/nodejs/node * branch refs/pull/58261/merge -> FETCH_HEAD ✔ Fetched commits as 292263e3780b..47a213a8ca55 -------------------------------------------------------------------------------- Auto-merging doc/api/diagnostics_channel.md [main 694cb28388] doc: update stability status for diagnostics_channel to experimental Author: idango10 <[email protected]> Date: Sat May 10 18:51:38 2025 +0300 1 file changed, 14 insertions(+) Auto-merging doc/api/diagnostics_channel.md error: commit 5d760725011411d86dc48b2b62ecaf8c7b88e65e is a merge but no -m option was given. fatal: cherry-pick failed [main 2ab8195a5c] fix: remove duplicate stability status from the parent Author: idango10 <[email protected]> Date: Sat May 10 21:11:54 2025 +0300 1 file changed, 6 deletions(-) ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/14979428769 |
idango10
force-pushed
the
idango/fix-58234
branch
from
47a213a to
18e3e05
Compare
|
@geeksilva97 hey, it seems to fail now because I merged |
No prob. Will try again |
RaisinTen
approved these changes
May 13, 2025
RaisinTen
removed
the
commit-queue-failed
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a4e833a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58234