-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
doc: clarify napi_get_value_string_* for bufsize 0 #58158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify napi_get_value_string_* for bufsize 0 #58158
Conversation
Review requested:
|
I would rather change it to say that if |
@tniessen , we discussed this PR in out last Node-API meeting on 5/9/2025. |
Co-authored-by: Vladimir Morozov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in acb3d92 |
This edge case is ambiguous and it is unclear from the existing documentation what happens in this case.