Skip to content

build: use FILE_OFFSET_BITS=64 even on 32-bit arch #58090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: use FILE_OFFSET_BITS=64 even on 32-bit arch #58090

wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

Refs: #57934

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 30, 2025
mcollina
mcollina approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v20.x PRs that may need to be released in v20.x labels Apr 30, 2025
@richardlau richardlau added the lts-watch-v22.x PRs that may need to be released in v22.x label Apr 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66520/

@bnoordhuis
Copy link
Member

s/even on/esp. on/ - on 64 bits architectures the define is a no-op because off_t is already 64 bits.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66523/

mhdawson
mhdawson approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS force-pushed the use-file-offset-bits-64-by-default branch from 6132c85 to 2f9406d Compare May 4, 2025 16:34
@RafaelGSS
Copy link
Member Author

CI was green. Landing it manually as I had to update commit title.

RafaelGSS added a commit that referenced this pull request May 6, 2025
@RafaelGSS @richardlau
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
74c8358 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS
Copy link
Member Author

Landed in 74c8358

@RafaelGSS RafaelGSS closed this May 6, 2025
targos pushed a commit that referenced this pull request May 16, 2025
@RafaelGSS @richardlau @targos
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
2e54653 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
@marco-ippolito marco-ippolito removed the lts-watch-v20.x PRs that may need to be released in v20.x label Jun 5, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@RafaelGSS @richardlau @marco-ippolito
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
0b1f466 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@RafaelGSS @richardlau @marco-ippolito
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
fc1fa7a 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 5, 2025
Open
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@RafaelGSS @richardlau @aduh95
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
04c8f59 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@aduh95 aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Jun 10, 2025
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RafaelGSS @nodejs-github-bot @bnoordhuis @mcollina @anonrig @richardlau @mhdawson @aduh95 @marco-ippolito