Skip to content

build: update macos runner to 15 #58078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: update macos runner to 15 #58078

wants to merge 2 commits into from
+7 −6

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 29, 2025 •
edited
Loading

Ref: #58069

cc @nodejs/build @nodejs/tsc

@anonrig anonrig requested review from jasnell and targos April 29, 2025 15:27
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 29, 2025
@anonrig anonrig added semver-major PRs that contain breaking changes and should be released in the next major version. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 29, 2025
@anonrig anonrig force-pushed the yagiz/update-macos-github-actions branch from 12575f2 to f95d7cd Compare April 29, 2025 15:33
@anonrig
Copy link
Member Author

anonrig commented Apr 29, 2025

cc @nodejs/platform-macos @nodejs/cpp-reviewers any idea how to fix this error?

@richardlau
Copy link
Member

cc @nodejs/platform-macos @nodejs/cpp-reviewers any idea how to fix this error?

I have no insights on how to fix the error, but if anyone is trying to recreate please note that the GitHub workflow deliberately runs with configure --error-on-warn which treats all warnings as errors.

@aduh95
Copy link
Contributor

aduh95 commented Apr 29, 2025

Could be #54576

@targos
Copy link
Member

targos commented Apr 29, 2025

The error is from https://github.com/v8/v8/blob/91d3eb34ec7936b5d1d4832192e1d6691c085fc0/include/v8-persistent-handle.h#L482-L497

I know from my V8 clone's ninja files that V8's build config sets -Wno-cast-function-type.
Since the warning comes from a V8 public header, it looks like we would have to disable this warning globally in our build.

@anonrig anonrig force-pushed the yagiz/update-macos-github-actions branch from f95d7cd to 6a389cd Compare April 29, 2025 16:28
@jakecastelli
Copy link
Member

I was trying to build main today on my mac (arm), my os was 15.1 and I got a bunch of errors building v8 similar to above @targos mentioned. But after upgrading my os to 15.4.1 the problem goes away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell Awaiting requested review from jasnell

@targos targos Awaiting requested review from targos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. meta Issues and PRs related to the general management of the project. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @nodejs-github-bot @richardlau @aduh95 @targos @jakecastelli