src: support namespace options in configuration #58073

pmarchini · 2025-04-29T10:11:54Z

This PR introduces namespace-scoped configuration options, starting with the testRunner namespace.

Adding a namespace corresponds to introducing a new parameter at the AddOption level:

 AddOption("--test-shard",
           "run test at specific shard",
           &EnvironmentOptions::test_shard,
           kAllowedInEnvvar,
+          OptionNamespaces::kTestRunnerNamespace);

Namespaces are centrally declared using:

#define OPTION_NAMESPACE_LIST(V) \
  V(kNoNamespace, "") \
  V(kTestRunnerNamespace, "testRunner")

All defined namespaces are automatically exposed via JSON Schema at doc/node-config-schema.json.

This addresses #57559 while setting the foundation for future namespace adoption and structured configuration!

Here is an extract of the new namespace:

.......
  "testRunner": {
    "type": "object",
    "additionalProperties": false,
    "properties": {
      "experimental-test-coverage": {
        "type": "boolean"
      },
      "experimental-test-module-mocks": {
        "type": "boolean"
      },
      "test-concurrency": {
        "type": "number"
      },
      "test-coverage-branches": {
        "type": "number"
      },
      "test-coverage-exclude": {
        "oneOf": [
          {
            "type": "string"
          },
          {
            "items": {
              "type": "string",
              "minItems": 1
            },
            "type": "array"
          }
        ]
      },
.......

nodejs-github-bot · 2025-04-29T10:12:00Z

Review requested:

@nodejs/config
@nodejs/cpp-reviewers
@nodejs/test_runner

lib/internal/test_runner/runner.js

src/node_options.cc

doc/api/cli.md

lib/internal/options.js

src/node.cc

src/node_config_file.cc

doc/api/cli.md

src/node_options.cc

src/node_config_file.cc

github-actions · 2025-06-05T18:53:27Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - src: support namespace options in configuration file
   ⚠  - fixup! src: support namespace options in configuration file
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/15474767772

nodejs-github-bot · 2025-06-06T07:54:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67291/

nodejs-github-bot · 2025-06-06T12:47:07Z

Landed in c1f090d

PR-URL: #58073 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Giovanni Bucci <[email protected]> Reviewed-By: Daniel Lemire <[email protected]>

Notable changes: doc: * deprecate utilisNativeError in favor of ErrorisError (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate Symbol.dispose/asyncDispose from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add autoClose option to FileHandle readableWebStream (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635

Notable changes: doc: * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) #58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635

Notable changes: doc: * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) #58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635

Notable changes: doc: * add Filip Skokan to TSC (Rafael Gonzaga) nodejs#58499 * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) nodejs#58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) nodejs#58564 * deprecate HTTP/2 priority signaling (Matteo Collina) nodejs#58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) nodejs#58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) nodejs#57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) nodejs#58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) nodejs#58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) nodejs#58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) nodejs#58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) nodejs#58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) nodejs#58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) nodejs#58073 permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) nodejs#58579 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) nodejs#58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) nodejs#58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) nodejs#58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) nodejs#58385 PR-URL: nodejs#58635

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 29, 2025

marco-ippolito added the config Issues or PRs related to the config subsystem label Apr 29, 2025

pmarchini mentioned this pull request May 3, 2025

add "test" namespace to node.config.json #57559

Closed

pmarchini force-pushed the feat/config-file-namespaces branch 2 times, most recently from e882bbf to 7b398ee Compare May 15, 2025 10:47

pmarchini commented May 22, 2025

View reviewed changes

lib/internal/test_runner/runner.js Show resolved Hide resolved

pmarchini commented May 22, 2025

View reviewed changes

src/node_options.cc Outdated Show resolved Hide resolved

pmarchini force-pushed the feat/config-file-namespaces branch 5 times, most recently from 0aeba3a to 738f977 Compare May 26, 2025 12:15

pmarchini commented May 26, 2025

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved